-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev into tokio_migration and fix warnings #683
Merge dev into tokio_migration and fix warnings #683
Conversation
Set MSRV to 1.41
…ault to 'librespot'
Replace version functions by constants
Co-authored-by: Johannesd3 <51954457+Johannesd3@users.noreply.github.com>
Is it too much CI @sashahilton00 ? |
separated stream for each seek
@Johannesd3 it looks fine. My only concern is whether the tests on the various different systems are run in parallel and ho long they take, not sure how much resource Github grants projects to run CI workloads. |
No, that's too much. It's 100 minutes per run, and I think that's 20 runs per month, that's not enough. (I don't know why mac os suddenly failed.) |
Github actions is free for public repos, right? It's only private repos that have the 2k monthly limit. |
Didn't know that, thx. Another inconvenience: It will take twice as long (15min) until the tests are finished ... I will try to rebase this PR using the latest changes from |
a65a2f7
to
bc4a530
Compare
bc4a530
to
2a5deba
Compare
The target directory should rather be cached by os + rustc version, but I have no idea how to achieve this. Anyway, I will close this PR and reopen it, as I want to see how much caching improves the speed. |
Any idea why the |
Yes, those |
Next try to check caching again, hopefully it's the last try. Sorry for spamming you. |
I don't quite understand the macOS error :( Apparently it's caused by caching, but I don't know why. |
9979616
to
11ce290
Compare
I reduced the scope of this PR to experiment further with CI without blocking this. I created a PR in my repository (Johannesd3#13) where I can test stuff. |
... and fix (new?) clippy lints. Clippy didn't like the naming of some types and enum variants, consecutive upper letters are probably reserved for constants.
Maybe it's possible to fast-forward this merge to avoid an additional (useless) merge commit, but I'm no github pr expert.